Date: Thu, 6 Jul 2017 20:59:40 +0300
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
To: Keith Packard <keithp@keithp.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dave Airlie <airlied@redhat.com>,
        dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE
 ioctls
Message-ID: <20170706175940.GA12629@intel.com>
References: <20170705221013.27940-1-keithp@keithp.com>
 <20170705221013.27940-4-keithp@keithp.com>
 <20170706075313.bn2exiklfabgc25t@phenom.ffwll.local>
 <20170706101604.GY12629@intel.com>
 <CAKMK7uHWxt58vi_+KWKopNGgcLDkW62xwPfH054v-XLoyfD0wQ@mail.gmail.com>
 <20170706140805.GZ12629@intel.com>
 <86tw2pbkcn.fsf@keithp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86tw2pbkcn.fsf@keithp.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 806
Lines: 21

On Thu, Jul 06, 2017 at 09:28:40AM -0700, Keith Packard wrote:
> Ville Syrj?l? <ville.syrjala@linux.intel.com> writes:
> 
> > Maybe, or maybe we want to turn the interrupt on in that case? That's
> > what the old ioctl does.
> 
> That's what I suggested in my reply to Daniel's review. Even if we add
> the accurate function, we'll still need the interrupt-enable case as a
> fallback for drivers which don't support the accurate path, right?

TBH I didn't even consider that case, but yeah makes sense. Otherwise
the counter won't start to tick and the result of the query is pretty
much useless.

I was mostly thinking of the 'seq = query(); wait(seq + n);' pattern
where we can avoid doing the full update more than once if we enable
the interrupt already during the query.

-- 
Ville Syrj?l?
Intel OTC