Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbdGFTFz (ORCPT ); Thu, 6 Jul 2017 15:05:55 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35103 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbdGFTFx (ORCPT ); Thu, 6 Jul 2017 15:05:53 -0400 Date: Thu, 6 Jul 2017 21:05:41 +0200 From: Corentin Labbe To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size Message-ID: <20170706190541.GA28678@Red> References: <20170706085334.25380-1-clabbe.montjoie@gmail.com> <20170706185205.f4jwskpnz4d3udvv@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170706185205.f4jwskpnz4d3udvv@flea> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 30 On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote: > On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote: > > The datasheet said that emac register size is 0x1000 not 0x104 > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > index 716e7d668dec..5a57b67c9b77 100644 > > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi > > @@ -406,7 +406,7 @@ > > emac: ethernet@1c30000 { > > compatible = "allwinner,sun8i-h3-emac"; > > syscon = <&syscon>; > > - reg = <0x01c30000 0x104>; > > + reg = <0x01c30000 0x1000>; > > The size is actually 0x10000. I fixed it and applied. > > The A64 DTSI has the same issue, can you send a patch for this one > too? > Yes Thanks for the fixing Regards Corentin Labbe