Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdGFTKK (ORCPT ); Thu, 6 Jul 2017 15:10:10 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:17822 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751817AbdGFTKJ (ORCPT ); Thu, 6 Jul 2017 15:10:09 -0400 Subject: Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx To: Johan Hovold References: <20170519200438.9502-1-d-gerlach@ti.com> <20170519200438.9502-6-d-gerlach@ti.com> <20170703165844.GD27842@localhost> CC: Tony Lindgren , Santosh Shilimkar , Russell King , Keerthy J , , , From: Dave Gerlach Message-ID: <931417b7-d080-3877-252a-a5d39706dfb3@ti.com> Date: Thu, 6 Jul 2017 14:08:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170703165844.GD27842@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.203] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 32 On 07/03/2017 11:58 AM, Johan Hovold wrote: > On Fri, May 19, 2017 at 03:04:38PM -0500, Dave Gerlach wrote: >> Add amx3_common_pm_init to create a dummy platform_device for >> pm33xx so that our pm33xx module can probe and am335x and am437x >> platforms to enable basic suspend to mem and standby support. >> >> Signed-off-by: Dave Gerlach >> --- > >> +void __init amx3_common_pm_init(void) >> +{ >> + struct platform_device_info devinfo = { }; > > You should make sure devinfo is zeroed, and also set .id to -1. Thanks for the comment, will look into updating this for next version. Regards, Dave > >> + struct am33xx_pm_platform_data *pdata; >> + >> + pdata = am33xx_pm_get_pdata(); >> + devinfo.name = "pm33xx"; >> + devinfo.data = pdata; >> + devinfo.size_data = sizeof(*pdata); >> + platform_device_register_full(&devinfo); >> +} > > Johan >