Subject: Re: [PATCH] integrity: get rid of unneeded initializations in
 integrity_iint_cache entries
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serge@hallyn.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Date: Thu, 06 Jul 2017 15:43:46 -0400
In-Reply-To: <20170706150424.GA21489@mail.hallyn.com>
References: <20170706145421.13223-1-jlayton@kernel.org>
         <20170706150424.GA21489@mail.hallyn.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-Id: <1499370226.3130.36.camel@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1495
Lines: 47

On Thu, 2017-07-06 at 10:04 -0500, Serge E. Hallyn wrote:
> Quoting Jeff Layton (jlayton@kernel.org):
> > From: Jeff Layton <jlayton@redhat.com>
> > 
> > The init_once routine memsets the whole object to 0, and then
> > explicitly sets some of the fields to 0 again. Just remove the explicit
> > initializations.
> > 
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> 
> Reviewed-by: Serge Hallyn <serge@hallyn.com>

Thanks, queued.

Mimi

> 
> > ---
> >  security/integrity/iint.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> > index 6fc888ca468e..187b7cb378be 100644
> > --- a/security/integrity/iint.c
> > +++ b/security/integrity/iint.c
> > @@ -153,14 +153,11 @@ static void init_once(void *foo)
> >  	struct integrity_iint_cache *iint = foo;
> >  
> >  	memset(iint, 0, sizeof(*iint));
> > -	iint->version = 0;
> > -	iint->flags = 0UL;
> >  	iint->ima_file_status = INTEGRITY_UNKNOWN;
> >  	iint->ima_mmap_status = INTEGRITY_UNKNOWN;
> >  	iint->ima_bprm_status = INTEGRITY_UNKNOWN;
> >  	iint->ima_read_status = INTEGRITY_UNKNOWN;
> >  	iint->evm_status = INTEGRITY_UNKNOWN;
> > -	iint->measured_pcrs = 0;
> >  }
> >  
> >  static int __init integrity_iintcache_init(void)
> > -- 
> > 2.13.0
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>