Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbdGFUbC (ORCPT ); Thu, 6 Jul 2017 16:31:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:60126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbdGFUbA (ORCPT ); Thu, 6 Jul 2017 16:31:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1185122B54 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=snawrocki@kernel.org Subject: Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX To: Jose Abreu Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Carlos Palminha , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , devicetree@vger.kernel.org References: <4dc8f06f-b9cf-6d3d-da88-51abb24c1724@kernel.org> From: Sylwester Nawrocki Message-ID: Date: Thu, 6 Jul 2017 22:30:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 24 On 07/06/2017 12:24 PM, Jose Abreu wrote: >>> +- edid-phandle: phandle to the EDID handler block. >> >> Could you make this property optional and when it is missing assume that device >> corresponding to the parent node of this node handles EDID? This way we could >> avoid having property pointing to the parent node. > > Hmm, this is for the CEC notifier. Do you mean I should grab the > parent device for the notifier? This property is already optional > if cec is not enabled though. Yes, device associated with the parent node. Something like: - edid-phandle - phandle to the EDID handler block; if this property is not specified it is assumed that EDID is handled by device described by parent node of the HDMI RX node Not sure if it is any better than always requiring edid-phandle property, even when it is pointing to the parent node. We would need a DT maintainer's opinion on that. -- Thanks, Sylwester