Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbdGFV45 (ORCPT ); Thu, 6 Jul 2017 17:56:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:38743 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbdGFV44 (ORCPT ); Thu, 6 Jul 2017 17:56:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,319,1496127600"; d="scan'208";a="989771628" Date: Thu, 6 Jul 2017 14:58:29 -0700 (PDT) From: Shivappa Vikas X-X-Sender: vikas@vshiva-Udesk To: Thomas Gleixner cc: Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, ravi.v.shankar@intel.com, vikas.shivappa@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com Subject: Re: [PATCH 16/21] x86/intel_rdt/cqm: Add mount,umount support In-Reply-To: Message-ID: References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-17-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 28 On Sun, 2 Jul 2017, Thomas Gleixner wrote: > On Mon, 26 Jun 2017, Vikas Shivappa wrote: >> >> list_for_each_entry_safe(rdtgrp, tmp, &rdt_all_groups, rdtgroup_list) { >> + /* Free any child rmids */ >> + llist = &rdtgrp->crdtgrp_list; >> + list_for_each_entry_safe(sentry, stmp, llist, crdtgrp_list) { >> + free_rmid(sentry->rmid); >> + list_del(&sentry->crdtgrp_list); >> + kfree(sentry); >> + } > > I'm pretty sure, that I've seen exactly this code sequence already. Please > create a helper instead of copying stuff over and over. Thats right, during rmdir_ctrl_mon which deletes all its child mon groups. Will fix. Thanks, Vikas > > Thanks, > > tglx >