Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbdGFW3j (ORCPT ); Thu, 6 Jul 2017 18:29:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbdGFW3i (ORCPT ); Thu, 6 Jul 2017 18:29:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F7EE2156A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 6 Jul 2017 18:29:35 -0400 From: Steven Rostedt To: Federico Vaga Cc: LKML Subject: Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file() Message-ID: <20170706182935.7a72ed14@gandalf.local.home> In-Reply-To: <20170605093118.29962-3-federico.vaga@vaga.pv.it> References: <20170605093118.29962-1-federico.vaga@vaga.pv.it> <20170605093118.29962-3-federico.vaga@vaga.pv.it> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 28 On Mon, 5 Jun 2017 11:31:18 +0200 Federico Vaga wrote: > show_file(name) and show_instance_file(&top_instance, name) are > equivalent. > > Remove the show_file() function in order to have a single function for > this task. Actually I find nothing wrong with having a helper function like this. IIRC, show_file() was first, and then show_instance_file() came later. There's some files that only exist for the top_instance, and I like the fact that this is annotated that way. I'm curious to know what the benefit of removing show_file() is? -- Steve > > Signed-off-by: Federico Vaga > --- > trace-list.c | 21 ++++++--------------- > trace-local.h | 2 -- > trace-show.c | 18 ++---------------- > trace-snapshot.c | 2 +- > 4 files changed, 9 insertions(+), 34 deletions(-) \