Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbdGFXW4 (ORCPT ); Thu, 6 Jul 2017 19:22:56 -0400 Received: from verein.lst.de ([213.95.11.211]:33835 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbdGFXWz (ORCPT ); Thu, 6 Jul 2017 19:22:55 -0400 Date: Fri, 7 Jul 2017 01:22:53 +0200 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , David Wayne Fugate , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NVMe: Added another device ID with stripe quirk Message-ID: <20170706232253.GA11119@lst.de> References: <1499379151-32479-1-git-send-email-david.fugate@intel.com> <20170706221754.GA10217@lst.de> <20170706223955.GA1200@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170706223955.GA1200@localhost.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 16 On Thu, Jul 06, 2017 at 06:39:56PM -0400, Keith Busch wrote: > That's true for all Intel controllers going forward, but this > is actually an older controller that pre-dates NOIOB. It's the exact > same as the 8086:0A54 model, but a particular vendor decided their > rebranded device needs to be made special with a different DID. Meh.. > > We all agree that's a terrible way to go about this for mutliple reasons, > but we can't go back in time to tell the decision makers of this folly. So > I think we need to let this last one go through with the quirk. > > Acked-by: Keith Busch Reluctantly-accepted-by: Christoph Hellwig