Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753188AbdGGAnp (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Jul 2017 20:43:45 -0400
Received: from mail.kernel.org ([198.145.29.99]:50600 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753105AbdGGAnm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Jul 2017 20:43:42 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0E9821C9B
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org
Date: Fri, 7 Jul 2017 09:43:39 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Stafford Horne <shorne@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, shuah@kernel.org,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        naresh.kamboju@linaro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with
 "--logdir -"
Message-Id: <20170707094339.49d57164003f662162dad9cf@kernel.org>
In-Reply-To: <20170706130658.GC2511@lianli.shorne-pla.net>
References: <149915006959.18583.13997841764160473197.stgit@devbox>
        <149915032497.18583.11626955093827357641.stgit@devbox>
        <20170705122506.6235765e@gandalf.local.home>
        <20170706130658.GC2511@lianli.shorne-pla.net>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 673
Lines: 32

On Thu, 6 Jul 2017 22:06:58 +0900
Stafford Horne <shorne@gmail.com> wrote:

> On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> > On Tue,  4 Jul 2017 15:38:55 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > 
> > > +    local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > +  else
> > > +    local testlog=`/proc/self/fd/1`
> > 
> > cute trick.
> 
> Shouldn't this be:
> 
>    local testlog=/proc/self/fd/1
> 
> without the backticks and subshell? We just want to write to the stdout
> file not execute it.

Yeah, it was my mistake...

Thank you!

> 
> Or am missing something.
> 
> -Stafford


-- 
Masami Hiramatsu <mhiramat@kernel.org>