Subject: Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return
 value
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>
References: <20170706215833.GA25411@embeddedgus>
Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
From: Mark yao <mark.yao@rock-chips.com>
Message-ID: <595EDC3C.1010801@rock-chips.com>
Date: Fri, 7 Jul 2017 08:56:28 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20170706215833.GA25411@embeddedgus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1026
Lines: 42

On 2017年07月07日 05:58, Gustavo A. R. Silva wrote:
> The right variable to check here is port, not dp.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @@
> expression x;
> identifier fld;
> @@
>
> * x = devm_kzalloc(...);
>    ... when != x == NULL
>    x->fld
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Thanks for the fix,

Acked-by: Mark Yao <mark.yao@rock-chips.com>

> ---
>   drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index 14fa1f8..9b0b058 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
>   			continue;
>   
>   		port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
> -		if (!dp)
> +		if (!port)
>   			return -ENOMEM;
>   
>   		port->extcon = extcon;


-- 
Ｍark Yao