MIME-version: 1.0
Content-transfer-encoding: 8BIT
Content-type: text/plain; charset="UTF-8"
Message-id: <595F0A55.9070801@samsung.com>
Date: Fri, 07 Jul 2017 13:13:09 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, myungjoo.ham@samsung.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: int3496: constify acpi_device_id.
In-reply-to: <dcce788befa9d8e0fa849c21229ea356efdb70b0.1499360077.git.arvind.yadav.cs@gmail.com>
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20170706165618epcas5p1b527daa8f6674282d0bf72fc9bad9461@epcas5p1.samsung.com>
        <dcce788befa9d8e0fa849c21229ea356efdb70b0.1499360077.git.arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 39

On 2017년 07월 07일 01:55, Arvind Yadav wrote:
> acpi_device_id are not supposed to change at runtime. All functions
> working with acpi_device_id provided by <acpi/acpi_bus.h> work with
> const acpi_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    1733	    352	      0	   2085	    825 drivers/extcon/extcon-intel-int3496.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    1797	    272	      0	   2069	    815 drivers/extcon/extcon-intel-int3496.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/extcon/extcon-intel-int3496.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c
> index 9d17984..49bf9c6 100644
> --- a/drivers/extcon/extcon-intel-int3496.c
> +++ b/drivers/extcon/extcon-intel-int3496.c
> @@ -174,7 +174,7 @@ static int int3496_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct acpi_device_id int3496_acpi_match[] = {
> +static const struct acpi_device_id int3496_acpi_match[] = {
>  	{ "INT3496" },
>  	{ }
>  };
> 

Applied it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics