Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbdGGEqr (ORCPT ); Fri, 7 Jul 2017 00:46:47 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:40995 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752466AbdGGEqp (ORCPT ); Fri, 7 Jul 2017 00:46:45 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="20979672" Subject: Re: [x86/time] 03fa63cc96: ACPI_Error:Table[DMAR]is_not_invalidated_during_early_boot_stage(#/tbxface -#) References: <20170706145412.GA30520@inn.lkp.intel.com> <20170707015445.GG5222@yexl-desktop> <1802eca6-9956-8287-40ea-55654bc0cba8@cn.fujitsu.com> <20170707030414.GJ5222@yexl-desktop> CC: Ye Xiaolong , , , , , , , , , , , From: Dou Liyang To: Thomas Gleixner Message-ID: Date: Fri, 7 Jul 2017 12:46:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170707030414.GJ5222@yexl-desktop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: 31FE246B4C73.AC3A5 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3063 Lines: 108 Hi Thomas, At 07/07/2017 11:04 AM, Ye Xiaolong wrote: > On 07/07, Dou Liyang wrote: >> Hi xiaolong, >> >> Really thanks for your testing. >> >> At 07/07/2017 09:54 AM, Ye Xiaolong wrote: >>> On 07/06, Thomas Gleixner wrote: >>>> On Thu, 6 Jul 2017, kernel test robot wrote: >>>> >>>>> commit: 03fa63cc96ab35592e0a7d522b8edbc1e6b02d22 ("x86/time: Initialize interrupt mode behind timer init") >>>> >>>>> +----------------+------------+------------+ >>>>> | | 43436935b7 | 03fa63cc96 | >>>>> +----------------+------------+------------+ >>>>> | boot_successes | 0 | 4 | >>>>> +----------------+------------+------------+ >>>> >>>> So 03fa63cc96 makes the box boot again. I'm confused as usual by the >>>> output of this tool., >>>> >>>>> kern :info : [ 0.005000] tsc: Fast TSC calibration using PIT >>>>> kern :info : [ 0.006000] tsc: Detected 2195.020 MHz processor >>>>> kern :info : [ 0.007000] Calibrating delay loop (skipped), value calculated using timer frequency.. 4390.04 BogoMIPS (lpj=2195020) >>>>> kern :info : [ 0.008001] pid_max: default: 90112 minimum: 704 >>>>> kern :info : [ 0.009037] ACPI: Core revision 20170303 >>>>> kern :err : [ 0.010002] ACPI Error: Table [DMAR] is not invalidated during early boot stage (20170303/tbxface-193) >>>> >>>> Sure we have a error message here, but compared to what? Compared to >>>> something which does not boot at all? >>> >>> Sorry for the confusion, here commit 43436935b7 boot failed due to OOM which >>> happened at the late stage of kernel boot while the ACPI error showed at the >>> early boot stage for commit 03fa63cc96 and it didn't appear in 43436935b7's >>> dmesg. >>> >> >> let's make the problem clearly firstly: >> >> 1) Commit 43436935b7 ("x86/xen: Bypass intr mode setup in enlighten_pv >> system") made kernel boot failed, which caused by OOM. >> It is so interesting! This patch only work for XEN in pv mode, if we boot a kernel w/o XEN, it will not work in fact. >> 2) Commit 03fa63cc96 ("x86/time: Initialize interrupt mode behind >> timer init") can make the kernel boot success again, but with an ACPI >> error happened. Indeed, the ACPI Error appeared with this patch. If x2apic is enabled in x86-64, initializing interrupt mode contains irq remapping setup and the ACPI DMAR table initialization. default_setup_apic_routing() enable_IR_x2apic() irq_remapping_prepare() intel_prepare_irq_remapping() dmar_table_init() this patch make interrupt mode setup before acpi_early_init() which has the check of ACPI table state in acpi_reallocate_root_table() where the ACPI Error generated. I have got a machine which supports x2apic. I am tracking the code, try to find out more. Thanks, dou. >> >> And both *1* and *2* used the same configuration showed in the >> attachment. >> >> Does anything I missed? > > Yes, this is exactly what I meant. > > Thanks, > Xiaolong >> >> Thanks, >> >> dou. >> >>> Thanks, >>> Xiaolong >>> >>>> >>>> Thanks, >>>> >>>> tglx >>>> >>> >>> >>> >> >> > > >