Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104AbdGGHDH (ORCPT ); Fri, 7 Jul 2017 03:03:07 -0400 Received: from mail-eopbgr10079.outbound.protection.outlook.com ([40.107.1.79]:20512 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751059AbdGGHDF (ORCPT ); Fri, 7 Jul 2017 03:03:05 -0400 From: Andy Duan To: Richard Leitner , "robh+dt@kernel.org" , "mark.rutland@arm.com" CC: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dev@g0hl1n.net" , Andrew Lunn Subject: RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Thread-Topic: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Thread-Index: AQHS9liVhz49Jf19SE+3rJ5oc5evWaJH0raAgAAKjoCAAASU8A== Date: Fri, 7 Jul 2017 07:03:01 +0000 Message-ID: References: <1499346330-12166-1-git-send-email-richard.leitner@skidata.com> <1499346330-12166-2-git-send-email-richard.leitner@skidata.com> <81105c77-d48f-271b-2de1-c877b9413184@skidata.com> In-Reply-To: <81105c77-d48f-271b-2de1-c877b9413184@skidata.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: skidata.com; dkim=none (message not signed) header.d=none;skidata.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [199.59.231.64] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM4PR0401MB2258;7:/mF7yyXLZHTPsq6j+83KXsoh51miWadg8uz5GC9J2VvgKRqHUuWKevmIdcwJqjd+gA30LKSAesEV/cP5Jtx+1IZXT8HsgJFo5qGaTlZMnycDS3ygDlb1AtZRMSEwATeTQ2PiD9Alt8BwXVJd3NXrpjSGzFPdtYp8kIV/CWDogueNURtlDoK2LwtE4SVPKzuJGf0rAkwOyRkOcNNgirZiTNyAi4ohWVUQLVXT9+yYlAvGIDm1TYjWdpbP6KIyJpYosF+S7/H2EYQ6Ku/5n2fGeS/NwP1iT5JJe0fJWP9HAJSjLQ/fRKHM//N0KhkLMbrHz4OA6tOdHPJbzCwBTuu0nc+6zD+oyC0QT7/aW8JOw1bq1E4VCM3aO5kTOUBGjtQMycwPpmfiVUUc1BOEz8PaNW0EK2IZ/eqsq0xNrpREbWo8mHz6NjljJJbyH18rkFCM1zikjsYWeQvqAtNyWO2M82g0+MVFUPrEDLkkfA5VotE3ABfWAmisK1u5IssLv6O2Qi6NYhuuEH9MeyaRCz6VHeURsV59gky8iMZJ86ZFIxWXPmjiNAiE8JV1hG9HkHgFIVMw4JyR8W5yIneSpV553eaYWUsrXeI+ncUuo0jWCi5XobeLoEn0tQxKHWFK6kyoVZWMqZJvGzm/gNmyDTJaRJeil9x7JQDPlZUE9HKY6abSEBKXvuxt0JYZ9nRI/U1W2pocc3PJrFyW5ED9xeoukLPEaMsObChIwFy2dmF2Y3GZU34oUPOXO19uXWgJLETvzTrV84ZZwSHlXMb5LTmmX/MCJ2RkbJ77jsEQbSZtXQg= x-ms-office365-filtering-correlation-id: 25c009c1-6c91-40d0-03ee-08d4c50634eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM4PR0401MB2258; x-ms-traffictypediagnostic: AM4PR0401MB2258: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(247924648384137)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(2017060910059)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4PR0401MB2258;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4PR0401MB2258; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(39850400002)(39840400002)(39860400002)(39410400002)(39450400003)(39400400002)(377454003)(66066001)(33656002)(93886004)(74316002)(6436002)(6246003)(305945005)(189998001)(6506006)(7696004)(55016002)(50986999)(53936002)(99286003)(76176999)(5250100002)(9686003)(229853002)(2501003)(5660300001)(54356999)(54906002)(4326008)(478600001)(25786009)(8936002)(8676002)(81166006)(102836003)(6116002)(3280700002)(3660700001)(7736002)(14454004)(3846002)(38730400002)(2950100002)(2900100001)(68736007)(2906002)(86362001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0401MB2258;H:AM4PR0401MB2260.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2017 07:03:01.3374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2258 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6773CZB003360 Content-Length: 869 Lines: 23 From: Richard Leitner Sent: Friday, July 07, 2017 1:51 PM >> Since it is common issue so long as using the PHY, can you move it into smsc >phy driver like in .smsc_phy_reset() function ? >> And get the reset pin from phy dts node. > >Some more points that come into my mind: > - The smsc_phy_reset function is registered as "soft_reset". Would it be OK to >use nRST in it? It is not reasonable. > - Would it be OK to call the phy_init_hw function from within the >smsc_phy_reset? No, phy_init_hw() already call .drv->soft_reset(). > - IMHO I'd have to move the reset gpio binding inside the phy node then. Isn't >that a pretty big change doing that for all PHYs/FECs? Would it be "worth" it? > To make the change to be common, there have big change for phy driver. Maybe somebody can give one good suggestion/solution for it. Andy