Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdGGJ0S (ORCPT ); Fri, 7 Jul 2017 05:26:18 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:8882 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbdGGJ0Q (ORCPT ); Fri, 7 Jul 2017 05:26:16 -0400 Subject: Re: [PATCH] irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers To: Marc Zyngier , References: <20170707083959.10349-1-marc.zyngier@arm.com> CC: Thomas Gleixner , Hanjun Guo , Agustin Vega-Frias , Ma Jun , Linuxarm From: John Garry Message-ID: Date: Fri, 7 Jul 2017 10:25:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170707083959.10349-1-marc.zyngier@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.161] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.595F53B3.0090,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 36b167aa3ba829495f65eaea0c5cd68d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 18 On 07/07/2017 09:39, Marc Zyngier wrote: > A number of irqchip implementations are (ab)using the irqdomain > allocator by passing a fwnode that is neither a FWNODE_OF or > a FWNODE_IRQCHIP. > > This is pretty bad, but it also feels pretty crap to force these > drivers to allocate their own irqchip_fwid when they already have > a proper fwnode. > > Instead, let's teach the irqdomain allocator about ACPI device > nodes, and add some lovely name generation code... Tested on > an arm64 D05 system. > Thanks FWIW, since I reported the issue: Tested-by: John Garry