Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdGGJbJ (ORCPT ); Fri, 7 Jul 2017 05:31:09 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:46991 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdGGJbG (ORCPT ); Fri, 7 Jul 2017 05:31:06 -0400 Subject: Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX To: Sylwester Nawrocki , Jose Abreu References: <4dc8f06f-b9cf-6d3d-da88-51abb24c1724@kernel.org> CC: , , "Carlos Palminha" , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , From: Jose Abreu Message-ID: <258a880c-8b4d-8201-b90a-44ed4d351daa@synopsys.com> Date: Fri, 7 Jul 2017 10:31:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.95] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 30 On 06-07-2017 21:30, Sylwester Nawrocki wrote: > On 07/06/2017 12:24 PM, Jose Abreu wrote: >>>> +- edid-phandle: phandle to the EDID handler block. >>> Could you make this property optional and when it is missing assume that device >>> corresponding to the parent node of this node handles EDID? This way we could >>> avoid having property pointing to the parent node. >> Hmm, this is for the CEC notifier. Do you mean I should grab the >> parent device for the notifier? This property is already optional >> if cec is not enabled though. > > Yes, device associated with the parent node. Something like: > > - edid-phandle - phandle to the EDID handler block; if this property is > not specified it is assumed that EDID is handled by device described > by parent node of the HDMI RX node > > Not sure if it is any better than always requiring edid-phandle property, > even when it is pointing to the parent node. We would need a DT maintainer's > opinion on that. I will change and resend. I also have to fix a kbuild error when cec is not enabled. Best regards, Jose Miguel Abreu > > -- > Thanks, > Sylwester