Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752382AbdGGLZw (ORCPT ); Fri, 7 Jul 2017 07:25:52 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:48520 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbdGGLZt (ORCPT ); Fri, 7 Jul 2017 07:25:49 -0400 Subject: Re: [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration To: Hans Verkuil , Jose Abreu , , References: <4e42b0be-fdef-b4d6-be92-ccce71dda49d@cisco.com> CC: Carlos Palminha , Hans Verkuil From: Jose Abreu Message-ID: Date: Fri, 7 Jul 2017 12:25:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4e42b0be-fdef-b4d6-be92-ccce71dda49d@cisco.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.95] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 67 Hi Hans, On 07-07-2017 12:16, Hans Verkuil wrote: > On 07/07/17 13:08, Jose Abreu wrote: >> When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h >> we can get build warnings like these ones: >> >> "warning: ‘struct cec_notifier’ declared inside parameter list will >> not be visible outside of this definition or declaration" >> >> Prevent these warnings by using forward declaration of notifier >> structure. >> >> Signed-off-by: Jose Abreu >> Cc: Carlos Palminha >> Cc: Hans Verkuil >> --- >> include/media/cec-notifier.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h >> index 298f996..84f9376 100644 >> --- a/include/media/cec-notifier.h >> +++ b/include/media/cec-notifier.h >> @@ -21,14 +21,14 @@ >> #ifndef LINUX_CEC_NOTIFIER_H >> #define LINUX_CEC_NOTIFIER_H >> >> -#include >> -#include >> - >> struct device; >> struct edid; >> struct cec_adapter; >> struct cec_notifier; >> >> +#include >> +#include >> + >> #if IS_REACHABLE(CONFIG_CEC_CORE) && IS_ENABLED(CONFIG_CEC_NOTIFIER) >> >> /** >> > Isn't it enough to add a forward declaration of cec_notifier in the previous > patch? E.g.: > > +#ifndef CONFIG_CEC_NOTIFIER > +struct cec_notifier; > +static inline void cec_register_cec_notifier(struct cec_adapter *adap, > + struct cec_notifier *notifier) > +{ > +} > +#endif > > Then this header doesn't need to change. Yeah, it should also work :) I will add to the previous patch and drop this one then. Best regards, Jose Miguel Abreu > > Regards, > > Hans