Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbdGGLtj (ORCPT ); Fri, 7 Jul 2017 07:49:39 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:8886 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdGGLti (ORCPT ); Fri, 7 Jul 2017 07:49:38 -0400 Subject: Re: [PATCH] irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers To: Marc Zyngier , References: <20170707083959.10349-1-marc.zyngier@arm.com> CC: Thomas Gleixner , Hanjun Guo , Agustin Vega-Frias , Ma Jun , John Garry From: Hanjun Guo Message-ID: <595F753E.9090903@huawei.com> Date: Fri, 7 Jul 2017 19:49:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170707083959.10349-1-marc.zyngier@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.595F7549.0141,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 36b167aa3ba829495f65eaea0c5cd68d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 24 On 2017/7/7 16:39, Marc Zyngier wrote: > A number of irqchip implementations are (ab)using the irqdomain > allocator by passing a fwnode that is neither a FWNODE_OF or > a FWNODE_IRQCHIP. > > This is pretty bad, but it also feels pretty crap to force these > drivers to allocate their own irqchip_fwid when they already have > a proper fwnode. > > Instead, let's teach the irqdomain allocator about ACPI device > nodes, and add some lovely name generation code... Tested on > an arm64 D05 system. > > Reported-by: John Garry > Signed-off-by: Marc Zyngier > --- > kernel/irq/irqdomain.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Thomas already queued this patch, but I did a test on D03 and it works. Thanks Hanjun