Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbdGGOuS (ORCPT ); Fri, 7 Jul 2017 10:50:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44956 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbdGGOsr (ORCPT ); Fri, 7 Jul 2017 10:48:47 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Jul 2017 20:18:46 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Abhijeet Dharmapurikar , Christophe JAILLET , Nicholas Troast , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup In-Reply-To: <20170706064957.GB22780@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> <1499084308-2232-3-git-send-email-kgunda@codeaurora.org> <20170706064957.GB22780@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 30 On 2017-07-06 12:19, Stephen Boyd wrote: > On 07/03, Kiran Gunda wrote: >> This patch cleans up the following. >> >> - Rename the "pa" to "pmic_arb". >> - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. >> - Rename the pa_{read,write}_data() functions to >> pmic_arb_{read,write}_data(). >> - Rename channel to APID. >> - Rename the HWIRQ_*() macros to hwirq_to_*(). >> - Clean up qpnpint_irq_set_type() and pmic_arb_find_apid() >> functions. >> >> Signed-off-by: Kiran Gunda >> --- >> drivers/spmi/spmi-pmic-arb.c | 454 >> +++++++++++++++++++++---------------------- >> 1 file changed, 227 insertions(+), 227 deletions(-) >> > > This patch is large and noisy. Have you tried running > scripts/objdiff on this to make sure nothing changed? The objdiff will not be helpful here as this patch is for the renaming and clean-up to address your multiple minor comments on the earlier patches, which has minor code changes. I have keenly checked the patch and made sure that there are no unintended changes, except (+ * v2 only.) one extra line in documentation of struct apid_data {. I will remove this and upload the next patch.