DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 53781158AAF
Date: Fri, 7 Jul 2017 12:18:00 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Arun Kalyanasundaram <arunkaly@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Tom Zanussi <tzanussi@gmail.com>, linux-kernel@vger.kernel.org,
        David Carrillo-Cisneros <davidcc@google.com>
Subject: Re: perf script: Question: Python trace processing script contains
 the tid of the process in the common_pid attribute
Message-ID: <20170707151800.GC3734@redhat.com>
References: <CAGjB_Bp0haKX+YPC5117yK440mTK1ZW3WBubt616hbKaQNxd6w@mail.gmail.com>
 <20170701144703.GA5504@redhat.com>
 <CAGjB_BryYM7sY-LqBzN=+54ae6ox60kjH3L9KXu-oBfZ1CPQVQ@mail.gmail.com>
 <20170705192545.GI27350@kernel.org>
 <20170705192640.GJ27350@kernel.org>
 <CAGjB_Bp0Rjq+CnrV6+1=wuOTtOq34kKp9JEfcwgygr1FwbAniQ@mail.gmail.com>
 <CAGjB_Bq3QLowpN2o_G5WBVzU6mNerErTP1emiBEryKjaqtdqyA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGjB_Bq3QLowpN2o_G5WBVzU6mNerErTP1emiBEryKjaqtdqyA@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 29

Em Wed, Jul 05, 2017 at 04:51:26PM -0700, Arun Kalyanasundaram escreveu:
> Arnaldo:
> So, I think what you are suggesting is, we should check the signature
> of the hook to determine if it has an additional attribute and only
> then should we provide the dict. May be something like this:
> 
> PyObject* custom_dict = PyObject_GetAttrString(handler, "other_fields_dict");
> if (custom_dict)
>     //Add dict to PyTuple
> 
> Do you think this would be a better approach?

I think that we should provide as much as possible the common info about
a sample at all the sample processing routines, be it the initial,
tracepoint specific one, the one for non-tracepoint samples and the
trace_unhandled one.

So scripts not using this optional argument will work with older
versions of the perf tool as well as with new ones that support it.

One could say that to use a script that wants this optional argument, a
new enough version of the tool is required.

So yeah, I think this is a better approach. The details of how to best
do this method signature signing need to be figured out, of course.

Thanks for working on this!

- Arnaldo