Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752156AbdGGQbD (ORCPT ); Fri, 7 Jul 2017 12:31:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:1644 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdGGQbB (ORCPT ); Fri, 7 Jul 2017 12:31:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,323,1496127600"; d="scan'208";a="122457366" Date: Fri, 7 Jul 2017 10:30:58 -0600 From: Ross Zwisler To: John Hubbard Cc: Ross Zwisler , linux-kernel@vger.kernel.org, "Anaczkowski, Lukasz" , "Box, David E" , "Kogut, Jaroslaw" , "Lahtinen, Joonas" , "Moore, Robert" , "Nachimuthu, Murugasamy" , "Odzioba, Lukasz" , "Rafael J. Wysocki" , "Rafael J. Wysocki" , "Schmauss, Erik" , "Verma, Vishal L" , "Zheng, Lv" , Andrew Morton , Dan Williams , Dave Hansen , Greg Kroah-Hartman , Jerome Glisse , Len Brown , Tim Chen , devel@acpica.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org Subject: Re: [RFC v2 0/5] surface heterogeneous memory performance information Message-ID: <20170707163058.GB22856@linux.intel.com> References: <20170706215233.11329-1-ross.zwisler@linux.intel.com> <7cb3b9c4-9082-97e9-ebfd-542243bf652b@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cb3b9c4-9082-97e9-ebfd-542243bf652b@nvidia.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 41 On Thu, Jul 06, 2017 at 10:30:46PM -0700, John Hubbard wrote: > On 07/06/2017 02:52 PM, Ross Zwisler wrote: > [...] > > > > The naming collision between Jerome's "Heterogeneous Memory Management > > (HMM)" and this "Heterogeneous Memory (HMEM)" series is unfortunate, but I > > was trying to stick with the word "Heterogeneous" because of the naming of > > the ACPI 6.2 Heterogeneous Memory Attribute Table table. Suggestions for > > better naming are welcome. > > > > Hi Ross, > > Say, most of the places (file names, function and variable names, and even > print statements) where this patchset uses hmem or HMEM, it really seems to > mean, the Heterogeneous Memory Attribute Table. That's not *always* true, but > given that it's a pretty severe naming conflict, how about just changing: > > hmem --> hmat > HMEM --> HMAT > > ...everywhere? Then you still have Heterogeneous Memory in the name, but > there is enough lexical distance (is that a thing? haha) between HMM and HMAT > to keep us all sane. :) > > With or without the above suggestion, there are a few places (Kconfig, comments, > prints) where we can more easily make it clear that HMM != HMEM (or HMAT), > so for those I can just comment on them separately in the individual patches. > > thanks, > john h Hi John, Sure, that change makes sense to me. I had initially tried to make this enabling more generic so that other, non-ACPI systems could use the same sysfs representation even if they got their performance numbers from some other source, but while implementing it pretty quickly became very tightly tied to the ACPI HMAT. - Ross