Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbdGGSUW (ORCPT ); Fri, 7 Jul 2017 14:20:22 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:35595 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbdGGSUS (ORCPT ); Fri, 7 Jul 2017 14:20:18 -0400 Subject: Re: device support in hpsa, was: Re: OOPS from cciss_ioctl in 4.12+git To: Christoph Hellwig Cc: Jens Axboe , Meelis Roos , Linux Kernel list , linux-block@vger.kernel.org, Don Brace , Scott Benesh , Scott Teel , Kevin Barnett , linux-scsi@vger.kernel.org, Hannes Reinecke References: <20170705225134.GA31786@infradead.org> <20170707150042.GA15445@infradead.org> <799cf0d6-658d-4124-1ba0-3962671e3f1e@kernel.dk> <1bc9895b-bfcb-9ff5-c046-277b0d67a94e@redhat.com> <20170707180857.GA19790@infradead.org> From: Laurence Oberman Message-ID: <1e3a19fa-1dab-b360-7dbb-bc6c007f6ddd@redhat.com> Date: Fri, 7 Jul 2017 14:20:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170707180857.GA19790@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 511 Lines: 14 On 07/07/2017 02:08 PM, Christoph Hellwig wrote: > On Fri, Jul 07, 2017 at 11:42:38AM -0400, Laurence Oberman wrote: >> What happens when hpsa_allow_any=1 with the Smart Array 64xx >> It should probe. > > But only if it has a HP vendor ID as far as I can tell. We'd > still need to add the compaq ids so that these controllers get > probed. But maybe it's time to add them and flip the hpsa_allow_any > default (maybe conditionally on a config option?) and mark cciss > deprecated. > Agreed, I vote yes.