Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752452AbdGGUcw (ORCPT ); Fri, 7 Jul 2017 16:32:52 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:36298 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbdGGUcv (ORCPT ); Fri, 7 Jul 2017 16:32:51 -0400 MIME-Version: 1.0 In-Reply-To: <1499447553.20988.3.camel@perches.com> References: <1499445024-23524-1-git-send-email-vichy.kuo@gmail.com> <1499447553.20988.3.camel@perches.com> From: pierre kuo Date: Sat, 8 Jul 2017 04:32:50 +0800 Message-ID: Subject: Re: [PATCH] printk: Modify operators of printed_len To: Joe Perches Cc: pmladek@suse.com, Sergey Senozhatsky , rostedt@goodmis.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 23 hi Joe: 2017-07-08 1:12 GMT+08:00 Joe Perches : > On Sat, 2017-07-08 at 00:30 +0800, Pierre Kuo wrote: >> In 8b1742c9c207, we remove printk-recursion detection code in >> vprintk_emit(), where it is the first place that printed_len calculated. >> After removing above detection, it seems we can directly assign the >> result of log_output to printed_len. > [] >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > [] >> @@ -1754,7 +1754,7 @@ asmlinkage int vprintk_emit(int facility, int level, >> if (dict) >> lflags |= LOG_PREFIX|LOG_NEWLINE; >> >> - printed_len += log_output(facility, level, lflags, dict, dictlen, text, text_len); >> + printed_len = log_output(facility, level, lflags, dict, dictlen, text, text_len); > > If this is appropriate, this should also remove the > initialization of printed_len and perhaps rename it too. I cannot quite understand the reason why need to rename. printed_len seems meet the meaning we expect for here. thanks for your friendly comment.