Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbdGGWHN (ORCPT ); Fri, 7 Jul 2017 18:07:13 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:34880 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbdGGWHK (ORCPT ); Fri, 7 Jul 2017 18:07:10 -0400 MIME-Version: 1.0 In-Reply-To: <20170707175805.6bd8f34d@gandalf.local.home> References: <20170705085905.6558-1-juri.lelli@arm.com> <20170707105316.whutk3h6x2h6xvyt@e106622-lin> <4582085.aKtjXTl7qR@aspire.rjw.lan> <20170707175805.6bd8f34d@gandalf.local.home> From: Joel Fernandes Date: Fri, 7 Jul 2017 15:07:09 -0700 Message-ID: Subject: Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE To: Steven Rostedt Cc: "Rafael J. Wysocki" , Juri Lelli , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Viresh Kumar , LKML , Linux PM , Vincent Guittot , Luca Abeni , claudio@evidence.eu.com, Tommaso Cucinotta , bristot@redhat.com, Mathieu Poirier , Todd Kjos , Andres Oportus , Morten Rasmussen , Dietmar Eggemann , Patrick Bellasi , Ingo Molnar , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1138 Lines: 35 Hi, On Fri, Jul 7, 2017 at 2:58 PM, Steven Rostedt wrote: > On Fri, 07 Jul 2017 15:11:45 +0200 > "Rafael J. Wysocki" wrote: > >> On Friday, July 07, 2017 11:53:16 AM Juri Lelli wrote: >> > On 07/07/17 12:46, Thomas Gleixner wrote: >> > > On Fri, 7 Jul 2017, Juri Lelli wrote: >> > > > How about SCHED_FLAG_SUGOV then? >> > > >> > > I know sugo della carne, but what's sugo V? >> > > >> > >> > Right.. can't really help not thinking about the same (especially close >> > to lunch) :) >> > >> > But the abbreviation stands for SchedUtil GOVernor (AFAIK). We already >> > have a SUGOV_KTHREAD_PRIORITY (that I just noticed I need to remove BTW) >> > in sched/cpufreq_schedutil.c. >> >> SCHED_FLAG_CPUFREQ_WORKER comes to mind, but it's somewhat long. >> > > It is rather long. Although I actually hate the SUGOV, it is easily > grepable. Just comment what it stands for. We can always change it > later. I was thinking why not just SCHED_FLAG_CPUFREQ. That says its for cpufreq purposes, and is a bit self-documenting. "WORKER" is a bit redundant and can be dropped in my opinion. thanks, -Joel