Message-ID: <1499468601.20988.7.camel@perches.com>
Subject: Re: [PATCH] printk: Modify operators of printed_len
From: Joe Perches <joe@perches.com>
To: pierre kuo <vichy.kuo@gmail.com>
Cc: pmladek@suse.com, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        rostedt@goodmis.org, linux-kernel@vger.kernel.org
Date: Fri, 07 Jul 2017 16:03:21 -0700
In-Reply-To: <CAOVJa8H-6wKzOuOYL5ASMiokTXR+kKqgs_Tg-ie-pE0OSzuBHQ@mail.gmail.com>
References: <1499445024-23524-1-git-send-email-vichy.kuo@gmail.com>
         <1499447553.20988.3.camel@perches.com>
         <CAOVJa8H-6wKzOuOYL5ASMiokTXR+kKqgs_Tg-ie-pE0OSzuBHQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1310
Lines: 35

On Sat, 2017-07-08 at 04:32 +0800, pierre kuo wrote:
> hi Joe:

Hello Pierre.

> 2017-07-08 1:12 GMT+08:00 Joe Perches <joe@perches.com>:
> > On Sat, 2017-07-08 at 00:30 +0800, Pierre Kuo wrote:
> > > In 8b1742c9c207, we remove printk-recursion detection code in
> > > vprintk_emit(), where it is the first place that printed_len calculated.
> > > After removing above detection, it seems we can directly assign the
> > > result of log_output to printed_len.
> > 
> > []
> > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > 
> > []
> > > @@ -1754,7 +1754,7 @@ asmlinkage int vprintk_emit(int facility, int level,
> > >       if (dict)
> > >               lflags |= LOG_PREFIX|LOG_NEWLINE;
> > > 
> > > -     printed_len += log_output(facility, level, lflags, dict, dictlen, text, text_len);
> > > +     printed_len = log_output(facility, level, lflags, dict, dictlen, text, text_len);
> > 
> > If this is appropriate, this should also remove the
> > initialization of printed_len and perhaps rename it too.
> 
> I cannot quite understand the reason why need to rename.
> printed_len seems meet the meaning we expect for here.

Verbosity.  To me, len would be adequate.

Anyway, the real point was the declaration of printed_len could
remove the " = 0" as it's now only set once.

cheers, Joe