Date: Tue, 17 Jun 2003 13:01:42 -0700
From: Andrew Morton <akpm@digeo.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: roy@karlsbakk.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] O_DIRECT for ext3 (2.4.21)
Message-Id: <20030617130142.50775749.akpm@digeo.com>
In-Reply-To: <1055861357.4240.11.camel@sisko.scot.redhat.com>
References: <20030615110106.GA8404@karlsbakk.net>
	<1055861357.4240.11.camel@sisko.scot.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1115
Lines: 32

"Stephen C. Tweedie" <sct@redhat.com> wrote:
>
> Hi,
> 
> On Sun, 2003-06-15 at 12:01, Roy Sigurd Karlsbakk wrote:
> > hi all
> > 
> > I've been waiting for the official O_DIRECT on ext3 for some time now, so I
> > thought perhaps it's time to get it into 2.4.22 or so. The patch I've used, is
> > the one below (for 2.4.21):
> 
> This is Andrea's patch,

Actually I'm the culprit.

> (like allowing direct IO in journaled data mode --- bad move ---

hmm, OK, it doesn't even vaguely work in journalled mode either...

I think the check should be implemented in (the new) ext3_open().  Because
checking the return from open() is the way in which a good application would
determine whether the underlying fs supports O_DIRECT.

Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
have forgotten to provide a way for the fs to be told about fcntl.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/