Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbdGHDZl (ORCPT ); Fri, 7 Jul 2017 23:25:41 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:48480 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbdGHDZj (ORCPT ); Fri, 7 Jul 2017 23:25:39 -0400 Date: Sat, 8 Jul 2017 11:25:12 +0800 From: jlee@suse.com To: "Rafael J. Wysocki" Cc: "Lee, Chun-Yi" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown , Michal Hocko Subject: Re: [PATCH v3] acpi: handle the acpi hotplug schedule error Message-ID: <20170708032512.jz7bxgmobzrf7dzp@linux-rasp2> References: <20170707062242.29588-1-jlee@suse.com> <1704918.scVG4c48Sb@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1704918.scVG4c48Sb@aspire.rjw.lan> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 57 Hi Rafael, On Fri, Jul 07, 2017 at 03:16:40PM +0200, Rafael J. Wysocki wrote: > On Friday, July 07, 2017 02:22:42 PM Lee, Chun-Yi wrote: > > Kernel should decrements the reference count of acpi device > > when the scheduling of acpi hotplug work failed, and evaluates > > _OST to notify BIOS the failure. > > > > v3: > > More simplify the code. (Rafael J. Wysocki) > > > > v2: > > To simplify the code. (Andy Shevchenko) > > > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Michal Hocko > > Reviewed-by: Andy Shevchenko > > Signed-off-by: "Lee, Chun-Yi" > > This has been applied too AFAICS. > I saw patches in linux-next. Thanks for your review. Joey Lee > > --- > > drivers/acpi/bus.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 784bda6..9d4fea6 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -432,11 +432,15 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) > > (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS)) > > driver->ops.notify(adev, type); > > > > - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > > + if (!hotplug_event) { > > + acpi_bus_put_acpi_device(adev); > > + return; > > + } > > + > > + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > > return; > > > > acpi_bus_put_acpi_device(adev); > > - return; > > > > err: > > acpi_evaluate_ost(handle, type, ost_code, NULL); > > >