Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750985AbdGHFOs (ORCPT ); Sat, 8 Jul 2017 01:14:48 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33926 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdGHFOq (ORCPT ); Sat, 8 Jul 2017 01:14:46 -0400 Date: Sat, 8 Jul 2017 14:12:51 +0900 From: Sergey Senozhatsky To: Pierre Kuo Cc: pmladek@suse.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH] printk: Modify operators of printed_len Message-ID: <20170708051251.GB488@tigerII.localdomain> References: <1499482273-10638-1-git-send-email-vichy.kuo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499482273-10638-1-git-send-email-vichy.kuo@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 41 On (07/08/17 10:51), Pierre Kuo wrote: > In 8b1742c9c207, we remove printk-recursion detection code in > vprintk_emit(), where it is the first place that printed_len calculated. > After removing above detection, it seems we can directly assign the > result of log_output to printed_len. > > Signed-off-by: Pierre Kuo Reviewed-by: Sergey Senozhatsky -ss > --- > kernel/printk/printk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index fc47863..a2a8cac 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -1701,7 +1701,7 @@ asmlinkage int vprintk_emit(int facility, int level, > size_t text_len = 0; > enum log_flags lflags = 0; > unsigned long flags; > - int printed_len = 0; > + int printed_len; > bool in_sched = false; > > if (level == LOGLEVEL_SCHED) { > @@ -1754,7 +1754,7 @@ asmlinkage int vprintk_emit(int facility, int level, > if (dict) > lflags |= LOG_PREFIX|LOG_NEWLINE; > > - printed_len += log_output(facility, level, lflags, dict, dictlen, text, text_len); > + printed_len = log_output(facility, level, lflags, dict, dictlen, text, text_len); > > logbuf_unlock_irqrestore(flags); > > -- > 1.7.9.5 >