Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752874AbdGHK20 (ORCPT ); Sat, 8 Jul 2017 06:28:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:41258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbdGHK2Y (ORCPT ); Sat, 8 Jul 2017 06:28:24 -0400 Date: Sat, 08 Jul 2017 11:28:19 +0100 (WEST) Message-Id: <20170708.112819.2140475148838704261.davem@davemloft.net> To: garsilva@embeddedor.com Cc: andrew@lunn.ch, nbd@openwrt.org, blogic@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_probe() From: David Miller In-Reply-To: <20170707202333.GA5114@embeddedgus> References: <20170707150831.Horde.MYtEbXeqxGS-hTg2bUv3DWt@gator4166.hostgator.com> <20170707202333.GA5114@embeddedgus> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 08 Jul 2017 03:28:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 520 Lines: 20 From: "Gustavo A. R. Silva" Date: Fri, 7 Jul 2017 15:23:34 -0500 > Remove useless local variables _match_, _soc_ and the code related. > > Notice that > > const struct of_device_id of_mtk_match[] = { > { .compatible = "mediatek,mt2701-eth" }, > {}, > }; > > So match->data is NULL. > > Suggested-by: Andrew Lunn > Signed-off-by: Gustavo A. R. Silva Applied, thanks. If someone needs this they can it back, in a less buggy form.