Date: Sat, 8 Jul 2017 14:01:58 +0300
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hari Prasath <gehariprasath@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, alan@linux.intel.com,
        rvarsha016@gmail.com, julia.lawall@lip6.fr, singhalsimran0@gmail.com,
        linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: atomisp: use kstrdup to replace kmalloc and
 memcpy
Message-ID: <20170708110157.jkpg6foz35lckdqu@ihha.localdomain>
References: <20170707144521.4520-1-gehariprasath@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170707144521.4520-1-gehariprasath@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1511
Lines: 43

Hi Hari,

On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote:
> kstrdup kernel primitive can be used to replace kmalloc followed by
> string copy. This was reported by coccinelle tool
> 
> Signed-off-by: Hari Prasath <gehariprasath@gmail.com>
> ---
>  .../media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c       | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> index 34cc56f..68db87b 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c
> @@ -144,14 +144,10 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia
>  	)
>  	{
>  		char *namebuffer;
> -		int namelength = (int)strlen(name);
> -
> -		namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL);
> -		if (namebuffer == NULL)
> -			return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY;
> -
> -		memcpy(namebuffer, name, namelength + 1);
>  
> +		namebuffer = kstrdup(name, GFP_KERNEL);
> +		if (!namebuffer)
> +			return -ENOMEM;

The patch also changes the return value in error cases. I believe the
caller(s) expect to get errors in the IA_CCS_ERR_* range.

>  		bd->name = fw_minibuffer[index].name = namebuffer;
>  	} else {
>  		bd->name = name;

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk