Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882AbdGHNxU (ORCPT ); Sat, 8 Jul 2017 09:53:20 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:49870 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751706AbdGHNxT (ORCPT ); Sat, 8 Jul 2017 09:53:19 -0400 Date: Sat, 8 Jul 2017 15:53:16 +0200 From: Markus Trippelsdorf To: Al Viro Cc: linux-kernel@vger.kernel.org Subject: Re: commit 67d7ddded32 (waitid(2): leave copyout of siginfo to syscall itself) breaks glibc posix/tst-waitid Message-ID: <20170708135316.GA277@x4> References: <20170708095644.GA272@x4> <20170708131218.GP10672@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170708131218.GP10672@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 23 On 2017.07.08 at 14:12 +0100, Al Viro wrote: > On Sat, Jul 08, 2017 at 11:56:44AM +0200, Markus Trippelsdorf wrote: > > Since: > > commit 67d7ddded322db99f451a7959d56ed6c70a6c4aa > > Author: Al Viro > > Date: Sun May 14 20:53:13 2017 -0400 > > > > waitid(2): leave copyout of siginfo to syscall itself > > > > the glibc posix/tst-waitid.c testcase fails: > > > > markus@x4 glibc-build % ./posix/tst-waitid > > waitid WNOHANG on stopped status 0 > > I think I see what's going on... We lose the distinction between "got > a PID" and "nothing, but that's not an error" a bit too early waitid() > case. Could you see if there are any problems left with the following > applied? No, everything looks nice now. Thanks. -- Markus