Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbdGHPzb (ORCPT ); Sat, 8 Jul 2017 11:55:31 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41928 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbdGHPza (ORCPT ); Sat, 8 Jul 2017 11:55:30 -0400 Date: Sat, 8 Jul 2017 08:55:27 -0700 From: Guenter Roeck To: Arvind Yadav Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2] hwmon: nct7802: constify attribute_group structures. Message-ID: <20170708155527.GA24961@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2518 Lines: 76 On Wed, Jul 05, 2017 at 10:41:18AM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6161 9400 0 15561 3cc9 drivers/hwmon/nct7802.o > > File size After adding 'const': > text data bss dec hex filename > 6465 9080 0 15545 3cb9 drivers/hwmon/nct7802.o > > Signed-off-by: Arvind Yadav Ok, I messed up ;-). Took this version. Thanks, Guenter > --- > Changes in v1: > Subject was not correct. Now comparing size of nct7802.c > > drivers/hwmon/nct7802.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c > index 12b94b0..2876c18 100644 > --- a/drivers/hwmon/nct7802.c > +++ b/drivers/hwmon/nct7802.c > @@ -704,7 +704,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_temp_group = { > +static const struct attribute_group nct7802_temp_group = { > .attrs = nct7802_temp_attrs, > .is_visible = nct7802_temp_is_visible, > }; > @@ -802,7 +802,7 @@ static umode_t nct7802_in_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_in_group = { > +static const struct attribute_group nct7802_in_group = { > .attrs = nct7802_in_attrs, > .is_visible = nct7802_in_is_visible, > }; > @@ -880,7 +880,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, > return attr->mode; > } > > -static struct attribute_group nct7802_fan_group = { > +static const struct attribute_group nct7802_fan_group = { > .attrs = nct7802_fan_attrs, > .is_visible = nct7802_fan_is_visible, > }; > @@ -898,7 +898,7 @@ static umode_t nct7802_fan_is_visible(struct kobject *kobj, > NULL > }; > > -static struct attribute_group nct7802_pwm_group = { > +static const struct attribute_group nct7802_pwm_group = { > .attrs = nct7802_pwm_attrs, > }; > > @@ -1011,7 +1011,7 @@ static SENSOR_DEVICE_ATTR(pwm3_auto_point4_pwm, S_IRUGO | S_IWUSR, > NULL > }; > > -static struct attribute_group nct7802_auto_point_group = { > +static const struct attribute_group nct7802_auto_point_group = { > .attrs = nct7802_auto_point_attrs, > }; >