Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbdGHP5f (ORCPT ); Sat, 8 Jul 2017 11:57:35 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:44482 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752935AbdGHP5e (ORCPT ); Sat, 8 Jul 2017 11:57:34 -0400 Date: Sat, 8 Jul 2017 08:57:31 -0700 From: Guenter Roeck To: Arvind Yadav Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: hwmon: adt7475: constify attribute_group structures. Message-ID: <20170708155731.GA13516@roeck-us.net> References: <6f75a80453097e5f05f26782b42ab48f0da8e502.1499232764.git.arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f75a80453097e5f05f26782b42ab48f0da8e502.1499232764.git.arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2413 Lines: 51 On Wed, Jul 05, 2017 at 11:04:04AM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 10055 7032 0 17087 42bf drivers/hwmon/adt7475.o > > File size After adding 'const': > text data bss dec hex filename > 10567 6520 0 17087 42bf drivers/hwmon/adt7475.o > > Signed-off-by: Arvind Yadav Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/adt7475.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c > index c803e3c..973f17a 100644 > --- a/drivers/hwmon/adt7475.c > +++ b/drivers/hwmon/adt7475.c > @@ -1205,14 +1205,14 @@ static SENSOR_DEVICE_ATTR_2(pwm3_auto_point2_pwm, S_IRUGO | S_IWUSR, show_pwm, > NULL > }; > > -static struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; > -static struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; > -static struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; > -static struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > -static struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > -static struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > -static struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > -static struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > +static const struct attribute_group adt7475_attr_group = { .attrs = adt7475_attrs }; > +static const struct attribute_group fan4_attr_group = { .attrs = fan4_attrs }; > +static const struct attribute_group pwm2_attr_group = { .attrs = pwm2_attrs }; > +static const struct attribute_group in0_attr_group = { .attrs = in0_attrs }; > +static const struct attribute_group in3_attr_group = { .attrs = in3_attrs }; > +static const struct attribute_group in4_attr_group = { .attrs = in4_attrs }; > +static const struct attribute_group in5_attr_group = { .attrs = in5_attrs }; > +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs }; > > static int adt7475_detect(struct i2c_client *client, > struct i2c_board_info *info)