Subject: Re: [PATCH v1 1/1] mux: consumer: Add dummy functions for
 !CONFIG_MULTIPLEXER case
To: sathyanarayanan.kuppuswamy@linux.intel.com
Cc: linux-kernel@vger.kernel.org, sathyaosid@gmail.com
References: <b401a6875042aa54f739403605ecaf30c9997aeb.1499463614.git.sathyanarayanan.kuppuswamy@linux.intel.com>
From: Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
Message-ID: <fe9f5e79-a415-e880-feb3-3a4eaa4ae4cb@axentia.se>
Date: Sat, 8 Jul 2017 22:55:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <b401a6875042aa54f739403605ecaf30c9997aeb.1499463614.git.sathyanarayanan.kuppuswamy@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2017 20:55:08.0190 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2558
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2039
Lines: 77

On 2017-07-07 23:41, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> 
> Add dummy functions to avoid compile time issues when CONFIG_MULTIPLEXER
> is not enabled.

Hi!

Consumers should "select MULTIPLEXER", so this does not make sense.
Or do you have a driver that has an optional mux consumer?

> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
>  include/linux/mux/consumer.h | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
> index 5577e1b..744a5b8 100644
> --- a/include/linux/mux/consumer.h
> +++ b/include/linux/mux/consumer.h
> @@ -16,6 +16,7 @@
>  struct device;
>  struct mux_control;
>  
> +#ifdef CONFIG_MULTIPLEXER
>  unsigned int mux_control_states(struct mux_control *mux);
>  int __must_check mux_control_select(struct mux_control *mux,
>  				    unsigned int state);
> @@ -29,4 +30,41 @@ void mux_control_put(struct mux_control *mux);
>  struct mux_control *devm_mux_control_get(struct device *dev,
>  					 const char *mux_name);
>  
> +#else
> +unsigned int mux_control_states(struct mux_control *mux)

static inline

Cheers,
peda

> +{
> +	return -ENODEV;
> +}
> +
> +int __must_check mux_control_select(struct mux_control *mux,
> +				    unsigned int state)
> +{
> +	return -ENODEV;
> +}
> +
> +int __must_check mux_control_try_select(struct mux_control *mux,
> +					unsigned int state)
> +{
> +	return -ENODEV;
> +}
> +
> +int mux_control_deselect(struct mux_control *mux)
> +{
> +	return -ENODEV;
> +}
> +
> +struct mux_control *mux_control_get(struct device *dev, const char *mux_name)
> +{
> +	return ERR_PTR(-ENODEV);
> +}
> +
> +void mux_control_put(struct mux_control *mux) {}
> +
> +struct mux_control *devm_mux_control_get(struct device *dev,
> +					 const char *mux_name)
> +{
> +	return ERR_PTR(-ENODEV);
> +}
> +#endif
> +
>  #endif /* _LINUX_MUX_CONSUMER_H */
>