Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdGHV0J (ORCPT ); Sat, 8 Jul 2017 17:26:09 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34269 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbdGHV0I (ORCPT ); Sat, 8 Jul 2017 17:26:08 -0400 MIME-Version: 1.0 In-Reply-To: <08b3c179-6e58-73c7-5221-4b9b12d7ea9c@axentia.se> References: <08b3c179-6e58-73c7-5221-4b9b12d7ea9c@axentia.se> From: Andy Shevchenko Date: Sun, 9 Jul 2017 00:26:06 +0300 Message-ID: Subject: Re: [PATCH v1 1/1] mux: Add new API to get mux_control ref by device name. To: Peter Rosin , "Krogerus, Heikki" Cc: Kuppuswamy Sathyanarayanan , "linux-kernel@vger.kernel.org" , Sathyanarayanan Kuppuswamy Natarajan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 29 On Sun, Jul 9, 2017 at 12:12 AM, Peter Rosin wrote: > On 2017-07-08 00:03, sathyanarayanan.kuppuswamy@linux.intel.com wrote: >> From: Kuppuswamy Sathyanarayanan >> >> Currently this driver only provides a single API, mux_control_get() to >> get mux_control reference based on mux_name, and also this API has tight >> dependency on device tree node. For devices, that does not use device >> tree, it makes it difficult to use this API. This patch adds new >> API to access mux_control reference based on device name, chip index and >> controller index value. > > I assume this is for the Intel USB Multiplexer that you sent a driver for > a month or so ago? If so, you still have not answered these questions: > > Is any other consumer in the charts at all? Can this existing consumer > ever make use of some other mux? If the answer to both those questions > are 'no', then I do not see much point in involving the mux subsystem at > all. The Broxton USB PHY driver could just as well write to the register > all by itself, no? > > that I asked in https://lkml.org/lkml/2017/5/31/58 > > What is the point of that driver? Without Heikki's blessing, NAK for this activity. -- With Best Regards, Andy Shevchenko