Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbdGILvB (ORCPT ); Sun, 9 Jul 2017 07:51:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41424 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbdGILvA (ORCPT ); Sun, 9 Jul 2017 07:51:00 -0400 Date: Sun, 9 Jul 2017 13:50:55 +0200 From: Greg Kroah-Hartman To: Okash Khawaja Cc: Jiri Slaby , Samuel Thibault , Alan Cox , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , speakup@linux-speakup.org, Chris Brannon Subject: Re: [patch 2/3] staging: speakup: use tty_kopen instead of tty_open_by_driver Message-ID: <20170709115055.GA14769@kroah.com> References: <20170708083803.GA23080@kroah.com> <20170709114153.157783481@gmail.com> <20170709114429.230337437@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170709114429.230337437@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 26 On Sun, Jul 09, 2017 at 12:41:55PM +0100, Okash Khawaja wrote: > This patch replaces call to tty_open_by_driver with a tty_kopen. > > Signed-off-by: Okash Khawaja > > --- > drivers/staging/speakup/spk_ttyio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/staging/speakup/spk_ttyio.c > +++ b/drivers/staging/speakup/spk_ttyio.c > @@ -164,7 +164,7 @@ static int spk_ttyio_initialise_ldisc(st > if (ret) > return ret; > > - tty = tty_open_by_driver(dev, NULL, NULL); > + tty = tty_kopen(dev); > if (IS_ERR(tty)) Hm, the "no tty layer" return value for this will be NULL. I doubt that's really a big deal, but perhaps just have that return PTR_ERR(-ENODEV) or something? thanks, greg k-h