Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbdGJD0H (ORCPT ); Sun, 9 Jul 2017 23:26:07 -0400 Received: from gateway30.websitewelcome.com ([192.185.150.24]:28314 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076AbdGJD0G (ORCPT ); Sun, 9 Jul 2017 23:26:06 -0400 X-Greylist: delayed 1264 seconds by postgrey-1.27 at vger.kernel.org; Sun, 09 Jul 2017 23:26:06 EDT Date: Sun, 9 Jul 2017 22:04:58 -0500 From: "Gustavo A. R. Silva" To: Felipe Balbi , Greg Kroah-Hartman , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] usb: gadget: udc-xilinx: compress return logic into one line Message-ID: <20170710030458.GA14639@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dUP0N-0007Ju-9l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.152.176]:46614 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 43 Simplify return logic to avoid unnecessary variable assignment. This issue was detected using Coccinelle and the following semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/udc-xilinx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index de207a9..552389d 100644 --- a/drivers/usb/gadget/udc/udc-xilinx.c +++ b/drivers/usb/gadget/udc/udc-xilinx.c @@ -1217,14 +1217,13 @@ static const struct usb_ep_ops xusb_ep_ops = { static int xudc_get_frame(struct usb_gadget *gadget) { struct xusb_udc *udc; - int frame; if (!gadget) return -ENODEV; udc = to_udc(gadget); - frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET); - return frame; + + return udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET); } /** -- 2.5.0