Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315AbdGJDfj (ORCPT ); Sun, 9 Jul 2017 23:35:39 -0400 Received: from gateway30.websitewelcome.com ([192.185.150.24]:28602 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbdGJDfi (ORCPT ); Sun, 9 Jul 2017 23:35:38 -0400 Date: Sun, 9 Jul 2017 22:10:55 -0500 From: "Gustavo A. R. Silva" To: Felipe Balbi , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] usb: gadget: fusb300_udc: compress return logic into one line Message-ID: <20170710031054.GA16519@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.152.176 X-Exim-ID: 1dUP68-000B8c-98 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.152.176]:46646 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 11 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 52 Simplify return logic to avoid unnecessary variable declaration and assignment. These issues were detected using Coccinelle and the following semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/udc/fusb300_udc.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c index e0c1b00..8738f03 100644 --- a/drivers/usb/gadget/udc/fusb300_udc.c +++ b/drivers/usb/gadget/udc/fusb300_udc.c @@ -659,22 +659,16 @@ static void fusb300_rdfifo(struct fusb300_ep *ep, static u8 fusb300_get_epnstall(struct fusb300 *fusb300, u8 ep) { - u8 value; u32 reg = ioread32(fusb300->reg + FUSB300_OFFSET_EPSET0(ep)); - value = reg & FUSB300_EPSET0_STL; - - return value; + return reg & FUSB300_EPSET0_STL; } static u8 fusb300_get_cxstall(struct fusb300 *fusb300) { - u8 value; u32 reg = ioread32(fusb300->reg + FUSB300_OFFSET_CSR); - value = (reg & FUSB300_CSR_STL) >> 1; - - return value; + return (reg & FUSB300_CSR_STL) >> 1; } static void request_error(struct fusb300 *fusb300) -- 2.5.0