Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbdGJDug (ORCPT ); Sun, 9 Jul 2017 23:50:36 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34928 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069AbdGJDue (ORCPT ); Sun, 9 Jul 2017 23:50:34 -0400 Date: Sun, 9 Jul 2017 22:50:31 -0500 From: Rob Herring To: Neil Armstrong Cc: jbrunet@baylibre.com, linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: clock: amlogic,gxbb-aoclkc: Update bindings Message-ID: <20170710035031.rdbi64ookkbq6zeo@rob-hp-laptop> References: <1499336663-23875-1-git-send-email-narmstrong@baylibre.com> <1499336663-23875-4-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499336663-23875-4-git-send-email-narmstrong@baylibre.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 17 On Thu, Jul 06, 2017 at 12:24:23PM +0200, Neil Armstrong wrote: > On the first revision of the bindings, only the gates + resets were known > in the AO Clock HW, but more registers used to configures AO clock are known > to be spread among the AO register space. > This patch adds these registers to the Ao Clock bindings with direct access > and shared extcon access. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) This looks like the binding might be too specific with a reg list of single registers, and you should define a system controller node instead. Depends on what else is in the "A0" block. Acked-by: Rob Herring