Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbdGJGWa (ORCPT ); Mon, 10 Jul 2017 02:22:30 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34291 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbdGJGW1 (ORCPT ); Mon, 10 Jul 2017 02:22:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170709195250.hu3psedjrvjkhivv@valkosipuli.retiisi.org.uk> References: <20170707144521.4520-1-gehariprasath@gmail.com> <20170708110157.jkpg6foz35lckdqu@ihha.localdomain> <20170709195250.hu3psedjrvjkhivv@valkosipuli.retiisi.org.uk> From: hari prasath Date: Mon, 10 Jul 2017 11:52:26 +0530 Message-ID: Subject: Re: [PATCH v2] staging: atomisp: use kstrdup to replace kmalloc and memcpy To: Sakari Ailus Cc: mchehab@kernel.org, "gregkh@linuxfoundation.org" , Alan Cox , Varsha Rao , Julia Lawall , SIMRAN SINGHAL , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2482 Lines: 65 On 10 July 2017 at 01:22, Sakari Ailus wrote: > On Sun, Jul 09, 2017 at 05:56:15PM +0530, hari prasath wrote: >> On 8 July 2017 at 16:31, Sakari Ailus wrote: >> > Hi Hari, >> > >> > On Fri, Jul 07, 2017 at 08:15:21PM +0530, Hari Prasath wrote: >> >> kstrdup kernel primitive can be used to replace kmalloc followed by >> >> string copy. This was reported by coccinelle tool >> >> >> >> Signed-off-by: Hari Prasath >> >> --- >> >> .../media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +++------- >> >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> >> >> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c >> >> index 34cc56f..68db87b 100644 >> >> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c >> >> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c >> >> @@ -144,14 +144,10 @@ sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi, struct ia >> >> ) >> >> { >> >> char *namebuffer; >> >> - int namelength = (int)strlen(name); >> >> - >> >> - namebuffer = (char *) kmalloc(namelength + 1, GFP_KERNEL); >> >> - if (namebuffer == NULL) >> >> - return IA_CSS_ERR_CANNOT_ALLOCATE_MEMORY; >> >> - >> >> - memcpy(namebuffer, name, namelength + 1); >> >> >> >> + namebuffer = kstrdup(name, GFP_KERNEL); >> >> + if (!namebuffer) >> >> + return -ENOMEM; >> > >> > The patch also changes the return value in error cases. I believe the >> > caller(s) expect to get errors in the IA_CCS_ERR_* range. >> >> Hi, >> >> In this particular case, the calling function just checks if it's not >> success defined by a enum. I think returning -ENOMEM would not effect, >> at least in this case. > > It might not, but the function now returns both negative Posix and positive > CSS error codes. The CSS error codes could well be converted to Posix but > it should be done consistently and preferrably in a separate patch. Hi Sakari, Thanks for your comments. I will stick with just replacing with kstrdup and retain the original error return value. I will send a v3. Regards, Hari > > -- > Sakari Ailus > e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk -- Regards, G.E.Hari Prasath