Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbdGJHOt (ORCPT ); Mon, 10 Jul 2017 03:14:49 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:37218 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbdGJHOs (ORCPT ); Mon, 10 Jul 2017 03:14:48 -0400 Date: Mon, 10 Jul 2017 09:14:42 +0200 From: Sebastian Andrzej Siewior To: Arvind Yadav Cc: tglx@linutronix.de, mingo@kernel.org, anna-maria@linutronix.de, boris.ostrovsky@oracle.com, rcochran@linutronix.de, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel: cpu: hotplug: constify attribute_group structures. Message-ID: <20170710071442.pvfbfknsn5hmjqk4@linutronix.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 19 On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 12582 15361 20 27963 6d3b kernel/cpu.o > > File size After adding 'const': > text data bss dec hex filename > 12710 15265 20 27995 6d5b kernel/cpu.o While there does not seem to be anything wrong with it, why did the file grow after the patch was applied? > Signed-off-by: Arvind Yadav Sebastian