Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbdGJHjE (ORCPT ); Mon, 10 Jul 2017 03:39:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:50593 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751163AbdGJHjD (ORCPT ); Mon, 10 Jul 2017 03:39:03 -0400 Message-ID: <1499672197.12673.1.camel@suse.com> Subject: Re: [PATCH] usb: isp1760: compress return logic into one line From: Oliver Neukum To: "Gustavo A. R. Silva" , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Mon, 10 Jul 2017 09:36:37 +0200 In-Reply-To: <20170710020007.GA30095@embeddedgus> References: <20170710020007.GA30095@embeddedgus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 404 Lines: 15 Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : > Simplify return logic to avoid unnecessary variable assignment. > > This issue was detected using Coccinelle and the following > semantic patch: > Hi, I need to ask: Where is the improvement? The compiler does not bother and for the human reader you do not do anything obvious and you decreased grepability. Regards Oliver