Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbdGJHtv (ORCPT ); Mon, 10 Jul 2017 03:49:51 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33200 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbdGJHtt (ORCPT ); Mon, 10 Jul 2017 03:49:49 -0400 From: Arvind Yadav To: bjorn@mork.no, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: usb: qmi_wwan: constify attribute_group structures. Date: Mon, 10 Jul 2017 13:19:07 +0530 Message-Id: <7567aa802cd3347aab19da6d4af6748f61e08f72.1499672630.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 16831 464 0 17295 438f drivers/net/usb/qmi_wwan.o File size After adding 'const': text data bss dec hex filename 16895 400 0 17295 438f drivers/net/usb/qmi_wwan.o Signed-off-by: Arvind Yadav --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 5894e3c..b2ddd5c 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -434,7 +434,7 @@ static ssize_t del_mux_store(struct device *d, struct device_attribute *attr, c NULL, }; -static struct attribute_group qmi_wwan_sysfs_attr_group = { +static const struct attribute_group qmi_wwan_sysfs_attr_group = { .name = "qmi", .attrs = qmi_wwan_sysfs_attrs, }; -- 1.9.1