Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbdGJIBz (ORCPT ); Mon, 10 Jul 2017 04:01:55 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33690 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbdGJIBx (ORCPT ); Mon, 10 Jul 2017 04:01:53 -0400 From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net Cc: netdev@vger.kernel.org, llinux-can@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: can: at91_can: constify attribute_group structures. Date: Mon, 10 Jul 2017 13:31:27 +0530 Message-Id: <3ffbac2d582a6fe8f0d430dcf0bb313226aa1bcf.1499673562.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 32 attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 6164 304 0 6468 1944 drivers/net/can/at91_can.o File size After adding 'const': text data bss dec hex filename 6228 240 0 6468 1944 drivers/net/can/at91_can.o Signed-off-by: Arvind Yadav --- drivers/net/can/at91_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index 0e0df0b..f37ce0e 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -1232,7 +1232,7 @@ static DEVICE_ATTR(mb0_id, S_IWUSR | S_IRUGO, NULL, }; -static struct attribute_group at91_sysfs_attr_group = { +static const struct attribute_group at91_sysfs_attr_group = { .attrs = at91_sysfs_attrs, }; -- 1.9.1