DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0A43780C1D
Subject: Re: [PATCH 1/3 v2] KVM: vmx: Enable VMFUNCs
To: Bandan Das <bsd@redhat.com>, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, linux-kernel@vger.kernel.org
References: <20170706230323.29952-1-bsd@redhat.com>
 <20170706230323.29952-2-bsd@redhat.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <71bb73d6-c64c-3fee-ea7d-4fa0f2d4682e@redhat.com>
Date: Mon, 10 Jul 2017 10:54:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170706230323.29952-2-bsd@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 35


>  /*
>   * The exit handlers return 1 if the exit was handled fully and guest execution
>   * may resume.  Otherwise they set the kvm_run parameter to indicate what needs
> @@ -7790,6 +7806,7 @@ static int (*const kvm_vmx_exit_handlers[])(struct kvm_vcpu *vcpu) = {
>  	[EXIT_REASON_XSAVES]                  = handle_xsaves,
>  	[EXIT_REASON_XRSTORS]                 = handle_xrstors,
>  	[EXIT_REASON_PML_FULL]		      = handle_pml_full,
> +	[EXIT_REASON_VMFUNC]                  = handle_vmfunc,
>  	[EXIT_REASON_PREEMPTION_TIMER]	      = handle_preemption_timer,
>  };
>  
> @@ -8111,6 +8128,9 @@ static bool nested_vmx_exit_handled(struct kvm_vcpu *vcpu)
>  	case EXIT_REASON_PML_FULL:
>  		/* We emulate PML support to L1. */
>  		return false;
> +	case EXIT_REASON_VMFUNC:
> +		/* VM functions are emulated through L2->L0 vmexits. */
> +		return false;

This would fit better into the second patch.

>  	default:
>  		return true;
>  	}
> 


Looks good to me.

-- 

Thanks,

David