Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbdGJKYg (ORCPT ); Mon, 10 Jul 2017 06:24:36 -0400 Received: from mail-eopbgr40063.outbound.protection.outlook.com ([40.107.4.63]:36032 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753418AbdGJKYe (ORCPT ); Mon, 10 Jul 2017 06:24:34 -0400 From: Ilan Tayari To: Arnd Bergmann , Saeed Mahameed CC: Matan Barak , Leon Romanovsky , Yossi Kuperman , Yevgeny Kliteynik , Boris Pismenny , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly Thread-Topic: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly Thread-Index: AQHS+WBWV2Xz59l9c0GrKu3AUIGijqJM2lLg Date: Mon, 10 Jul 2017 10:24:25 +0000 Message-ID: References: <20170710093842.2921914-1-arnd@arndb.de> In-Reply-To: <20170710093842.2921914-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [109.67.22.132] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM4PR0501MB1923;7:jE0Ujk3NSJvm0IeUyBOqt49tfUzhYoGz3H42eFG0QcKTsZVVEH++OvWcN3K2/twrRM62gYiEEWrv0gdrj1JJ12ynh4ZtsobXCe7zfha3+LNGMOWit6DX2HgTHsXDa5euWcCosveSl3nGxDm4HNuCoAzQn6Kz1YQKzz/UGK8uuAwk0wpfQ0hC5c3wahmUZXPJgtG0/4834O8ovDGbCyGo9wONssMwOkbq9+H1rqO6e5Y1MN7FWI+0QJSYwTiiPHHVKXwfizpOSRaRuzDUEs5MJXsxrkgYwK3lyTj1W8mI8iHt0tpRCNDnMHg34Io/+Ir8pXESLN/a8E40UKKr94u/cTodDAq60bSU7/v5rJch2dMBWaWNE+ACzJ3V87jbi/ZQpHTtTf1Vins4bIPQzI0fJ3wL6hdPjnLfXF4tSLwnasRUgnHO6NwT53lu0Oe/m19H/ousKdo2D4hRi5EMe6cjxMgKhJwvmHvJC4vejInOWCecPM+S+/pwYA6Jn/8m1go3N53TvW23aB0gCcOyhP+ms53fhB8H8+h46u1jbLipBnsnfJeO9d+NqY7GI0Y+/FV/Vjr8s8VOMuCQvnq+60rIad/4FejbnPjiIsLpIX3HhIvRVAXBUHTSRc6upJmg9p/YNxCJw6/ge+vzQt9El1sq7B1fGhXg9QJVT5GIPSP1e4U+pz2esWspzYzC/Qm/ZOLAuG5Ic1jxghwo9+T6py1SJHxE2Y095SBlKgLdKwelNXi6JF2RpefQDe+jAy6jEMPYKz0/ybKJROrp0HVtQoxujuocUHz524NT00CRNUIHBLg= x-ms-office365-filtering-correlation-id: af783013-485f-4b75-9353-08d4c77dd6c6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM4PR0501MB1923; x-ms-traffictypediagnostic: AM4PR0501MB1923: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(236129657087228)(148574349560750)(209349559609743); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(2017060910075)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4PR0501MB1923;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4PR0501MB1923; x-forefront-prvs: 03648EFF89 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39840400002)(39450400003)(39850400002)(39410400002)(39400400002)(13464003)(6436002)(81166006)(25786009)(8676002)(478600001)(6506006)(6116002)(189998001)(3846002)(305945005)(6636002)(2950100002)(102836003)(7736002)(66066001)(5250100002)(3660700001)(5660300001)(55016002)(38730400002)(33656002)(99286003)(54906002)(86362001)(9686003)(2906002)(3280700002)(50986999)(4326008)(229853002)(8936002)(74316002)(7696004)(6246003)(2900100001)(53936002)(76176999)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB1923;H:AM4PR0501MB1940.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2017 10:24:25.3010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB1923 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6AAOdwr008654 Content-Length: 947 Lines: 29 > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Subject: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly > > The new IPSec offload code introduced a build error: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function > `mlx5e_ipsec_build_inverse_table': > ipsec_rxtx.c:(.text+0x556): undefined reference > > Another patch was added on top to fix the build error, but > that introduced a new bug, as we now use the remainder of > the division rather than the result. > > This makes it use the correct helper function instead. > > Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit > builds") > Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data > path") > Signed-off-by: Arnd Bergmann This is a good fix. Values are now generated correctly. Sorry for the mixup. Thank you Arnd! Reviewed-by: Ilan Tayari