Subject: Re: [PATCH 2/2] x86/elf: remove the unnecessary ADDR_NO_RANDOMIZE
 checks in stack_maxrandom_size() and randomize_stack_top()
To: Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
        Cyrill Gorcunov <gorcunov@openvz.org>, linux-kernel@vger.kernel.org
References: <20170710111429.GA20038@redhat.com>
 <20170710111458.GA20047@redhat.com>
From: Dmitry Safonov <dsafonov@virtuozzo.com>
Message-ID: <7250417d-e0c7-7506-92b7-10e9088f5184@virtuozzo.com>
Date: Mon, 10 Jul 2017 14:58:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <20170710111458.GA20047@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2017 11:58:42.6402 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1730
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1522
Lines: 46

On 07/10/2017 02:14 PM, Oleg Nesterov wrote:
> PF_RANDOMIZE is set by load_elf_binary() only if ADDR_NO_RANDOMIZE is not
> set, no need to re-check after that.that.that.that.that.that.that.that.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Dmitry Safonov <dsafonov@virtuozzo.com>

> ---
>   arch/x86/mm/mmap.c | 3 +--
>   fs/binfmt_elf.c    | 3 +--
>   2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
> index 6369d04..81db3e9 100644
> --- a/arch/x86/mm/mmap.c
> +++ b/arch/x86/mm/mmap.c
> @@ -50,8 +50,7 @@ unsigned long tasksize_64bit(void)
>   static unsigned long stack_maxrandom_size(unsigned long task_size)
>   {
>   	unsigned long max = 0;
> -	if ((current->flags & PF_RANDOMIZE) &&
> -		!(current->personality & ADDR_NO_RANDOMIZE)) {
> +	if (current->flags & PF_RANDOMIZE) {
>   		max = (-1UL) & __STACK_RND_MASK(task_size == tasksize_32bit());
>   		max <<= PAGE_SHIFT;
>   	}
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index 5075fd5..569c82e 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -666,8 +666,7 @@ static unsigned long randomize_stack_top(unsigned long stack_top)
>   {
>   	unsigned long random_variable = 0;
>   
> -	if ((current->flags & PF_RANDOMIZE) &&
> -		!(current->personality & ADDR_NO_RANDOMIZE)) {
> +	if (current->flags & PF_RANDOMIZE) {
>   		random_variable = get_random_long();
>   		random_variable &= STACK_RND_MASK;
>   		random_variable <<= PAGE_SHIFT;
> 


-- 
              Dmitry