Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932399AbdGJN6P (ORCPT ); Mon, 10 Jul 2017 09:58:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932311AbdGJN6M (ORCPT ); Mon, 10 Jul 2017 09:58:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C73C43DBD3 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C73C43DBD3 Message-ID: <1499695083.6130.38.camel@redhat.com> Subject: Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever From: Rik van Riel To: Michal Hocko , Andrew Morton Cc: Mel Gorman , Tetsuo Handa , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, LKML , Michal Hocko Date: Mon, 10 Jul 2017 09:58:03 -0400 In-Reply-To: <20170710074842.23175-1-mhocko@kernel.org> References: <20170710074842.23175-1-mhocko@kernel.org> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 10 Jul 2017 13:58:07 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 13 On Mon, 2017-07-10 at 09:48 +0200, Michal Hocko wrote: > Johannes and Rik had some concerns that this could lead to premature > OOM kills. I agree with them that we need a better throttling > mechanism. Until now we didn't give the issue described above a high > priority because it usually required a really insane workload to > trigger. But it seems that the issue can be reproduced also without > having an insane number of competing threads [3]. My worries stand, but lets fix the real observed bug, and not worry too much about the theoretical bug for now. Acked-by: Rik van Riel