Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932347AbdGJONq (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Jul 2017 10:13:46 -0400
Received: from mail-yb0-f195.google.com ([209.85.213.195]:34002 "EHLO
        mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932217AbdGJONo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Jul 2017 10:13:44 -0400
Date: Mon, 10 Jul 2017 09:13:42 -0500
From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Gregory Fong <gregory.0xf0@gmail.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@broadcom.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Ralf Baechle <ralf@linux-mips.org>, Markus Mayer <mmayer@broadcom.com>,
        Arnd Bergmann <arnd@arndb.de>, Eric Anholt <eric@anholt.net>,
        Justin Chen <justinpopo6@gmail.com>, Doug Berger <opendmb@gmail.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:BROADCOM BCM47XX MIPS ARCHITECTURE" 
        <linux-mips@linux-mips.org>,
        linux-pm@vger.kernerl.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v3 3/4] dt-bindings: Document MIPS Broadcom STB power
 management nodes
Message-ID: <20170710141342.fghqil4px5ylj336@rob-hp-laptop>
References: <20170706222225.9758-1-f.fainelli@gmail.com>
 <20170706222225.9758-4-f.fainelli@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170706222225.9758-4-f.fainelli@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1007
Lines: 51

On Thu, Jul 06, 2017 at 03:22:24PM -0700, Florian Fainelli wrote:
> Document the different nodes required for supporting S2/S3/S5 suspend
> states on MIPS-based Broadcom STB SoCs.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  .../devicetree/bindings/mips/brcm/soc.txt          | 153 +++++++++++++++++++++
>  1 file changed, 153 insertions(+)

A couple of nits on the node names, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> +Example:
> +
> +	memory-controller: memc@0 {

memory-controller@0

> +		compatible = "brcm,brcmstb-memc", "simple-bus";
> +		ranges = <0x0 0x0 0xa000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		memc-arb@1000 {
> +			...
> +		};
> +
> +		memc-ddr@2000 {
> +			...
> +		};
> +
> +		ddr-phy@6000 {
> +			...
> +		};
> +	};


> +Example:
> +
> +	timers: timers@4067c0 {

timer@...

> +		compatible = "brcm,bcm7425-timers", "brcm,brcmstb-timers";
> +		reg = <0x4067c0 0x40>;
> +		interrupts = <&periph_intc 19>;
> +	};
> -- 
> 2.9.3
>