Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbdGJPda (ORCPT ); Mon, 10 Jul 2017 11:33:30 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:35357 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754396AbdGJPd1 (ORCPT ); Mon, 10 Jul 2017 11:33:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170502121816.10572-2-marek.vasut+renesas@gmail.com> References: <20170502121816.10572-1-marek.vasut+renesas@gmail.com> <20170502121816.10572-2-marek.vasut+renesas@gmail.com> From: Geert Uytterhoeven Date: Mon, 10 Jul 2017 17:33:20 +0200 X-Google-Sender-Auth: 7MlYy5verN0AdlCnDuQpLRF-19Y Message-ID: Subject: Re: [PATCH V3 2/2] mfd: Add ROHM BD9571MWV-M MFD PMIC driver To: Marek Vasut Cc: Linux-Renesas , Lee Jones , Marek Vasut , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1493 Lines: 44 Hi Marek, On Tue, May 2, 2017 at 2:18 PM, Marek Vasut wrote: > Add the MFD part of the ROHM BD9571MWV-M PMIC driver and MAINTAINERS > entry. The MFD part only specifies the regmap bits for the PMIC and > binds the subdevs together. > > Signed-off-by: Marek Vasut > Cc: linux-kernel@vger.kernel.org > Cc: Geert Uytterhoeven > Cc: Lee Jones > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -133,6 +133,19 @@ config MFD_BCM590XX > help > Support for the BCM590xx PMUs from Broadcom > > +config MFD_BD9571MWV > + tristate "ROHM BD9571MWV PMIC" > + select MFD_CORE > + select REGMAP_I2C Missing "select REGMAP_IRQ". Else it fails with: drivers/built-in.o: In function `bd9571mwv_remove': :(.text+0x103190): undefined reference to `regmap_del_irq_chip' drivers/built-in.o: In function `bd9571mwv_probe': :(.text+0x10332c): undefined reference to `regmap_add_irq_chip' :(.text+0x103358): undefined reference to `regmap_irq_get_domain' :(.text+0x103394): undefined reference to `regmap_del_irq_chip' Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds