Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754565AbdGJQmT (ORCPT ); Mon, 10 Jul 2017 12:42:19 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58605 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbdGJQmR (ORCPT ); Mon, 10 Jul 2017 12:42:17 -0400 Date: Mon, 10 Jul 2017 18:42:06 +0200 From: Peter Zijlstra To: Andi Kleen Cc: Aubrey Li , tglx@linutronix.de, len.brown@intel.com, rjw@rjwysocki.net, tim.c.chen@linux.intel.com, arjan@linux.intel.com, paulmck@linux.vnet.ibm.com, yang.zhang.wz@gmail.com, x86@kernel.org, linux-kernel@vger.kernel.org, Aubrey Li Subject: Re: [RFC PATCH v1 00/11] Create fast idle path for short idle periods Message-ID: <20170710164206.5aon5kelbisxqyxq@hirez.programming.kicks-ass.net> References: <1499650721-5928-1-git-send-email-aubrey.li@intel.com> <20170710084647.zs6wkl3fumszd33g@hirez.programming.kicks-ass.net> <20170710144609.GD31832@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170710144609.GD31832@tassilo.jf.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 15 On Mon, Jul 10, 2017 at 07:46:09AM -0700, Andi Kleen wrote: > > So how much of the gain is simply due to skipping NOHZ? Mike used to > > carry a patch that would throttle NOHZ. And that is a _far_ smaller and > > simpler patch to do. > > Have you ever looked at a ftrace or PT trace of the idle entry? > > There's just too much stuff going on there. NOHZ is just the tip > of the iceberg. I have, and last time I did the actual poking at the LAPIC (to make NOHZ happen) was by far the slowest thing happening. Data to indicate what hurts how much would be a very good addition to the Changelogs. Clearly you have some, you really should have shared.